Skip to content

Conversation

andy-k-improving
Copy link
Contributor

@andy-k-improving andy-k-improving commented Sep 23, 2025

Description

This PR aims to:

  1. Update existing the mem0 configuration compose logic for flexibility
  2. Add Neptune Analytics as choice of Vector backend support

Code changes:

  • Update _initialize_client to extract and centralise the responsibility of creating mem0 configuration object out from individual _configure*_backend().
  • Introduce new method _configure_neptune_analytics_backend() which responsible to composite the json sub-block for the vector-store configuration for Neptune Analytics
  • Update test_mem0_service_client_init() to test the option of Neptune Analytics vector option and make sure error being thrown when there > 1 vector backend being configured.

Related Issues

Documentation PR

strands-agents/docs#262

Type of Change

New configuration option

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andy-k-improving
Copy link
Contributor Author

@cagataycali hi,
I have updated the comments and logic, the PR is ready again.
Would you mind to trigger the build and have another look?
Thanks!

cagataycali
cagataycali previously approved these changes Oct 7, 2025
@cagataycali cagataycali disabled auto-merge October 7, 2025 00:08
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@cagataycali Hi, would mind to have another look?
Thanks!

cagataycali
cagataycali previously approved these changes Oct 11, 2025
@cagataycali cagataycali enabled auto-merge (squash) October 14, 2025 19:00
Copy link
Contributor

@JackYPCOnline JackYPCOnline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename functions and update docstrings accordingly.

Signed-off-by: Andy Kwok <[email protected]>
auto-merge was automatically disabled October 14, 2025 21:37

Head branch was pushed to by a user without write access

Signed-off-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@JackYPCOnline Hi, I have updated the method names and the docString, would you mind to have a look?
Thanks

Signed-off-by: Andy Kwok <[email protected]>
@cagataycali cagataycali enabled auto-merge (squash) October 15, 2025 18:25
@cagataycali cagataycali merged commit b372dcc into strands-agents:main Oct 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants